side quest for screenshot diffs #1160
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Irev-Dev
changed the title
Irev-Dev
force-pushed
the
kurt-image-diff-tests
branch
from
eefc527
to
282954e
Compare
|
so rad, love this approach so much |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@paultag forced me to add some image diffing logic to the e2e tests, not full utilized as of yet.
I'm expecting e2e test to fail until #1154 merges
comment I left in slack
Fun fact, a bunch of my e2e were broken in CI but working locally, until a hunch told me to try pulling the lastest engine and they're broken locally to now (:raised_hands: failing only in CI is the worst)
Maybe related to the units/grid/scale stuff? did that go live?
Because we click at exact px coords and what code that generates depends on the engine scene and it's scaling, there's naturally going to be some coupling here. It should just be a matter of me go through and updating some numbers so I'm not worried about it, and I can imagine this happening too often.