Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tags are globals #2795

Merged
merged 5 commits into from
Jun 25, 2024
Merged

tags are globals #2795

merged 5 commits into from
Jun 25, 2024

Conversation

jessfraz
Copy link
Contributor

No description provided.

Signed-off-by: Jess Frazelle <github@jessfraz.com>
Copy link

qa-wolf bot commented Jun 25, 2024

QA Wolf here! As you write new code it's important that your test coverage is keeping up.
Click here to request test coverage for this PR!

Copy link

vercel bot commented Jun 25, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
modeling-app ✅ Ready (Inspect) Visit Preview Jun 25, 2024 5:16pm

@jessfraz
Copy link
Contributor Author

the snapshots are from lees nuke the grid PR :)

Signed-off-by: Jess Frazelle <github@jessfraz.com>
Copy link

codecov bot commented Jun 25, 2024

Codecov Report

Attention: Patch coverage is 80.00000% with 9 lines in your changes missing coverage. Please review.

Project coverage is 86.38%. Comparing base (da6cd5c) to head (b1582eb).
Report is 2 commits behind head on main.

Files Patch % Lines
src/wasm-lib/kcl/src/executor.rs 82.14% 5 Missing ⚠️
src/wasm-lib/kcl/src/ast/types.rs 76.47% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2795      +/-   ##
==========================================
- Coverage   86.39%   86.38%   -0.01%     
==========================================
  Files          61       61              
  Lines       23579    23609      +30     
==========================================
+ Hits        20370    20395      +25     
- Misses       3209     3214       +5     
Flag Coverage Δ
wasm-lib 86.38% <80.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jessfraz jessfraz merged commit 8fe2d33 into main Jun 25, 2024
22 of 24 checks passed
@jessfraz jessfraz deleted the global-tags branch June 25, 2024 17:35
@Irev-Dev Irev-Dev mentioned this pull request Jun 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant