Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

safe parse #996

Merged
merged 3 commits into from
Nov 6, 2023
Merged

safe parse #996

merged 3 commits into from
Nov 6, 2023

Conversation

Irev-Dev
Copy link
Collaborator

@Irev-Dev Irev-Dev commented Nov 4, 2023

added a safeParse method to the kclSingleton that adds errors correctly.

There are still uses of parse as there are situations where we're parsing code out side of the user's ux loop

resolves #994

Copy link

vercel bot commented Nov 4, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
modeling-app ✅ Ready (Inspect) Visit Preview Nov 6, 2023 6:47am

@Irev-Dev Irev-Dev marked this pull request as ready for review November 6, 2023 06:39
@Irev-Dev Irev-Dev enabled auto-merge (squash) November 6, 2023 06:42
@Irev-Dev Irev-Dev enabled auto-merge (squash) November 6, 2023 06:43
@Irev-Dev Irev-Dev merged commit 4bd08f7 into main Nov 6, 2023
7 checks passed
@Irev-Dev Irev-Dev deleted the kurt-safe-parse branch November 6, 2023 06:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

no kcl errors are being thrown anymore in the app
1 participant