Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

KWin code incorrectly references openbox. #2

Closed
ghost opened this issue Apr 21, 2011 · 4 comments
Closed

KWin code incorrectly references openbox. #2

ghost opened this issue Apr 21, 2011 · 4 comments

Comments

@ghost
Copy link

ghost commented Apr 21, 2011

In fact this dumps a awk error if you happen to use kwin. Below patch seems to do the job.

From 419cd0999774944192497ab84cdc6bd6067df47c Mon Sep 17 00:00:00 2001
From: Adam Young atyrelyoung@gmail.com
Date: Thu, 21 Apr 2011 02:08:10 -0700
Subject: [PATCH] KWin parsing incorrectly references openbox.


screenfetch-dev | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/screenfetch-dev b/screenfetch-dev
index 7490c7e..6f9f4cc 100755
--- a/screenfetch-dev
+++ b/screenfetch-dev
@@ -352,7 +352,7 @@ detectwmtheme () {
'Metacity') if [ "gconftool-2 -g /apps/metacity/general/theme" ]; then Win_theme="$(gconftool-2 -g /apps/metacity/general/theme)"; fi ;;
'Xfwm4') if [ -f ${XDG_CONFIG_HOME:-${HOME}/.config}/xfce4/xfconf/xfce-perchannel-xml/xfwm4.xml ]; then Win_theme="$(xfconf-query -c xfwm4 -p /general/theme)"; fi;;
'IceWM') if [ -f $HOME/.icewm/theme ]; then Win_theme="$(awk -F"[",/]" '!/#/ {print $2}' $HOME/.icewm/theme)"; fi;;

  • 'KWin') if [ -f $HOME/.kde/share/config/kwinrc ]; then Win_theme="$(awk -F"[<,>]" '/<theme/ { getline; print $3 }' ${XDG_CONFIG_HOME:-${HOME}/.config}/openbox/rc.xml)"; fi;;
  • 'KWin') if [ -f $HOME/.kde/share/config/plasmarc ]; then Win_theme="$(awk -F"[<=>]" '/^name=/ { getline; print $2 }' ${HOME}/.kde/share/config/plasmarc)"; else Win_theme="Not Present"; fi;;
    'Emerald') if [ -f $HOME/.emerald/theme/theme.ini ]; then Win_theme="$(for a in /usr/share/emerald/themes/* $HOME/.emerald/themes/*; do cmp "$HOME/.emerald/theme/theme.ini" "$a/theme.ini" &>/dev/null && basename "$a"; done)"; fi;;
    'FVWM') Win_theme="Not Present";;
    'DWM') Win_theme="Not Present";;
    --
    1.7.4.4
@ghost ghost closed this as completed Apr 21, 2011
@ghost
Copy link
Author

ghost commented Apr 21, 2011

I forgot just how bad the markdown is here, I'll e-mail the patches just in case.

@Kwpolska
Copy link
Contributor

Don't do that, just fork the repo, add it and make a pull request. Wouldn't you mind doing it for yourself?

@ghost
Copy link
Author

ghost commented Apr 21, 2011

Sure thing

On Apr 21, 2011, at 3:39 AM, Kwpolska
reply@reply.github.com
wrote:

Don't do that, just fork the repo, add it and make a pull request. Wouldn't you mind doing it for yourself?

Reply to this email directly or view it on GitHub:
#2 (comment)

@Kwpolska
Copy link
Contributor

I added your patches, they're waiting to be pulled.

Cheers,
-- Kwpolska (http://kwpolska.co.cc)
O< ascii ribbon campaign - stop html mail - www.asciiribbon.org

KittyKatt pushed a commit that referenced this issue Aug 22, 2012
KittyKatt pushed a commit that referenced this issue May 13, 2013
KittyKatt pushed a commit that referenced this issue May 22, 2013
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant