Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

modification in ChannelInactive of HTTPRequestHandler. #239

Merged
merged 1 commit into from
Apr 26, 2020
Merged

modification in ChannelInactive of HTTPRequestHandler. #239

merged 1 commit into from
Apr 26, 2020

Conversation

RudraniW
Copy link
Contributor

@RudraniW RudraniW commented Apr 1, 2020

This PR makes corrections in ChannelInactive of HTTPRequestHandler to decrement connectionCount. This fixes issue Kitura/Kitura#1501

@RudraniW RudraniW changed the title modification in ChannelInactive of HTTPRequestHandler to decrement connectionCount modification in ChannelInactive of HTTPRequestHandler. Apr 1, 2020
@mbarnach
Copy link
Member

mbarnach commented Apr 3, 2020

Nice catch! Indeed it fixes Kitura/Kitura#1501!
I've cherry-picked the solution in PR#238 to try to address some more issues (crashes if keep alive is set to anything else than unlimited, etc.)
I think the CI failure is not relevant, can we re-run it and merge?

@pushkarnk pushkarnk merged commit 1a62753 into master Apr 26, 2020
@ianpartridge ianpartridge deleted the connectionLimit branch April 28, 2020 12:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@RudraniW @mbarnach @pushkarnk