Make sure wait() isn't called on the event loop #79
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ClientRequest.end() makes the actual HTTP request, the response for which is received over the HTTPClientHandler. Further, the HTTPClientHandler may either execute HTTP redirection i.e creating a new ClientRequest or simply calling the `callback` supplied by the user. In both the cases we could again call ClientRequest.end() on the event loop. This isn't good because this method internally invokes `ClientBootstrap.connect(...).wait()` and swift-nio strictly disallows calling `wait()` on the event loop. This fix moves the redirection invocations and the callback invocations to a DispatchQueue. On the DispatchQueue, whenever we wish to work with the `Channel`, we call back into the event loop.
nethraravindran
approved these changes
Aug 29, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This partly fixes #66
ClientRequest.end() makes the actual HTTP request, the response for which is received over the HTTPClientHandler. Further, the HTTPClientHandler may either execute HTTP redirection i.e creating a new ClientRequest or simply calling the
callbacksupplied by the user. In both the cases we could again call ClientRequest.end() on the event loop. This isn't good because this method internally invokesClientBootstrap.connect(...).wait()and swift-nio strictly disallows callingwait()on the event loop. This fix moves the redirection invocations and the callback invocations to a DispatchQueue. On the DispatchQueue, whenever we wish to work with theChannel, we call back into the event loop.