Add property to set encoding format for Date properties.
#110
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pushkarnk
reviewed
May 29, 2019
README.md
Outdated
|
|
||
| You can change this behaviour by overriding the default value of the property `dateEncodingStrategy`. The dateEncodingStrategy will apply to all Date properties on your Model. | ||
|
|
||
| The example below defines a model which will have its Date properties encoded and decoded as a timestamp” |
There was a problem hiding this comment.
The ” at the end of this line looks like a typo?
pushkarnk
reviewed
May 29, 2019
Sources/SwiftKueryORM/Model.swift
Outdated
| @@ -19,6 +19,18 @@ import KituraContracts | |||
| import Foundation | |||
| import Dispatch | |||
|
|
|||
| /// Defines the supported formats for persisiting properties of type `Date`. | |||
| public enum DateEncodingFormat { | |||
| // time - Corresponds to the `time` column type | |||
There was a problem hiding this comment.
If we intend to have these comments (describing each case) to be a part of the API docs, they'd need to start with ///
There was a problem hiding this comment.
Also, I think we must document these in the API docs :)
pushkarnk
approved these changes
May 29, 2019
This was referenced Jun 5, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR add a property to
Modelwhich allows the user to specify a chosen format for encoding any properties which are of typeDateto their database.The PR also updates the ORM to respect the value of the property when creating a table from a Model.