-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(Camera): Synchronize image slices and cameras #615
base: main
Are you sure you want to change the base?
Conversation
❌ Deploy Preview for volview-dev failed. Why did it fail? →Built without sensitive environment variables
|
The only issue right now, it that it seems the camera is reset when changing images (which defeat the purpose of having camera synchronized). I think it may have something to do with |
I'm not sure about the order VTK.js camera is updated on switching images. But maybe to diagnose: keep the existing reset stuff, (might be setting needed camera parameters not included in the "synced" ones) and add a composable/hook to trigger the position, focalpont, etc sync after the resets. |
I'm not sure where or how to do that. What shoud I hook for ? |
I'ed want to test if the problem is the timing of the camera property sync vs something else. So could add some temp code to call the sync function on a button press, or wherever you see a camera reset. |
It's still unclear to me how you want to test this. What I could tell so far, is that the properties of the sync cameras are well updated. I looked in the pinia store, and I could see the values changing for all cameras when sync. However, when I change image, it resets these properties, and because images are sync, it resets to all of them. |
I tried to monitor the events, but all I can see when changing image is an event called |
This feature will allow to synchronize images (i.e. slices) and cameras, so it will be easy to compare images from different modalities for a given subject for example