wrap text to fit inside workflow step boxes #37
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is still a WIP as it only works properly if "Show Script" button has already been clicked before the workflow is selected.
| while (word = words.pop()) { | ||
| line.push(word); | ||
| tspan.text(line.join(" ")); | ||
| if (tspan.node().getComputedTextLength() > width) { |
There was a problem hiding this comment.
The problem is here: getComputedTextLength() returns zero when the editor div is hidden, presumably because it is of size 0x0.
|
Thanks for doing this! Hope to get to this tomorrow. |
|
Fixed things up a bit and it should now be ready to merge. |
jeffbaumes
added a commit
that referenced
this pull request
Oct 15, 2014
wrap text to fit inside workflow step boxes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@jeffbaumes This is still a WIP as it only works properly if the "Show Script" button has already been clicked before the workflow is selected. Nonetheless, I wanted to share it with you as-is to see if you have any suggestions on how to get this functionality working more robustly.