Clean up some test-related stuff #405
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Include gtest.h via test_eigen.h. I was on the fence about doing this since it isn't absolutely necessary, but the purpose of test_eigen.h is to define additional Google Test assertions, so it makes sense to do so. Also add and use static instances of the comparators, which produces slightly better messages when an assertion fails.
Modify some tests that only need to load plugins for a single test to call load_all_plugins in that test. Modify other tests to use TEST_LOAD_PLUGINS, as introduced in 8a5fe46.
|
Mac build succeeded: https://open.cdash.org/buildSummary.php?buildid=5158139 |
linus-sherrill
approved these changes
Nov 27, 2017
|
Linux build succeeded: https://open.cdash.org/buildSummary.php?buildid=5158205 |
|
Windows build failure: https://open.cdash.org/buildSummary.php?buildid=5158235 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Include
gtest.hviatest_eigen.h. Improve test matrix comparison helpers. Always delay tests loading plugins until a test case is actually going to execute.