doc(ts): WebsocketSession addAttachment definition #96
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jourdain
reviewed
Apr 19, 2022
| * @param payload The binary data to send | ||
| * @returns The id assigned to the binary attachment | ||
| */ | ||
| addAttachment(payload: Blob): number |
There was a problem hiding this comment.
I'm not familiar with the JS side, but are you sure it is a number rather than a string that id such attachment?
There was a problem hiding this comment.
You're right; one loc = one error, sorry. :-)
bourdaisj
force-pushed
the
add-attachment-ts-def
branch
from
bcd2eb7
to
e870635
Compare
|
🎉 This PR is included in version 1.6.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Simply add a missing typescript definition.