Cmake include paths adds './COMPONENT' and './libraries'

[emusgrave]

I'm a newb with cmake, but when I installed g3log using it and then included the package in my project, I got errors related to it not finding directories of /COMPONENT and /libraries. It looks like maybe the following line in CPackLists.txt needs to be put before the INCLUDES keyword?

g3log/CPackLists.txt

Line 40 in 376c417

COMPONENT libraries)

Relevant cmake documentation:
https://cmake.org/cmake/help/v3.12/command/install.html#installing-targets

Can anyone else confirm this, or am I just missing something?

[KjellKod]

Please let us know what platform you are on and what versions you are using.

[emusgrave]

I'm installing via vcpkg, which is set to use the very latest commit of g3log (1.3.2-95, commit ref 376c417).

vcpkg has installed g3log successfully on both Windows and Clear Linux, but the issue happens when using it in another project.

Cmake is version 3.14.5 on Clear Linux, and 3.14.19050301-MSVC_2 on Windows (Visual Studio 2019).

Edit: Here is the configuration that vcpkg is doing for the install: https://github.com/microsoft/vcpkg/blob/master/ports/g3log/portfile.cmake

[KjellKod]

FYI @myd7349 can you check this out?

[myd7349]

@KjellKod Sorry for the delay. I will confirm this.

[myd7349]

Hi! @emusgrave Thanks for your report. It turns out to be caused by a mistake I made in #312 and I have just created a PR to fix it. Once merged, I will update g3log's portfile in vcpkg.

[myd7349]

Hi! @emusgrave This issue has been fixed in vcpkg too.