Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Memory leak #428

Closed
DlubalSmidJaroslav opened this issue Jan 10, 2022 · 1 comment · Fixed by #430
Closed

Memory leak #428

DlubalSmidJaroslav opened this issue Jan 10, 2022 · 1 comment · Fixed by #430
Labels
bug

Comments

@DlubalSmidJaroslav
Copy link
Contributor

Describe the bug
filesinkhelper.ipp, function g3::internal::createLogFile, in the failure cause, unique_ptr::release is called instead of unique_ptr::reset, which leaks the allocated std::ofstream object - release returns the internal pointer and sets unique_ptr to nullptr WITHOUT deleting the object (i.e. transfers ownership).
See here for reference.
@KjellKod
Copy link
Owner

Good find. In this error case it should of course do reset. Please create a pull request that addresses this issue.

g3log is community driven

@DlubalSmidJaroslav DlubalSmidJaroslav mentioned this issue Jan 11, 2022
Merged
KjellKod pushed a commit that referenced this issue Jan 11, 2022
@DlubalSmidJaroslav @jardik
Fixes #428: memory leak in g3::internal::createLogFile (#430)
a7192f2 
Co-authored-by: Jaroslav Smid <smidjar2.reg@email.cz>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fixes #428: memory leak in g3::internal::createLogFile
2 participants
@KjellKod @DlubalSmidJaroslav