SOName needs to be less volatile #402
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
KjellKod
requested changes
Apr 5, 2021
CMakeLists.txt
Outdated
| @@ -89,9 +89,11 @@ IF ( NOT VERSION ) | |||
| message( STATUS "version base: ${VERSION-BASE}" ) | |||
| message( STATUS "version remainder: ${VERSION-REMAINDER}" ) | |||
| SET(BUILD_NUMBER ${VERSION-BASE}) | |||
| SET(VERSION ${MAJOR_VERSION}.${MINOR_VERSION}.${BUILD_NUMBER}-${VERSION-REMAINDER}) | |||
| SET(SOFT_VERSION ${MAJOR_VERSION}.${MINOR_VERSION}.${BUILD_NUMBER}-${VERSION-REMAINDER}) | |||
There was a problem hiding this comment.
Did you mean soversion? AFAIK SOFT_VERSION is not a reserved keyword in cmake
https://cmake.org/cmake/help/latest/prop_tgt/SOVERSION.html#prop_tgt:SOVERSION
|
Revised based on discussion on #403. |
KjellKod
approved these changes
Apr 9, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The SOName of the created library changes with every tiny change to the code. This makes the library impossible to package, as well as a host of other problems. This patch makes the SO name take only the major component of the version.
There is no new code or functionality.
This change applies only to the ABI. There is no change to the API.
Cross-Platform Testing
Testing Advice
Run Test Alternatives:
ctestctest -Vfor verbose outputmake test