Reduce default min fill amount and validate with subgraph minFill #2319
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Ignored Deployment
|
|
Spotted some odd behavior. These three links all point to listings of the same credit: First listing is from early December, second from mid January, third from mid February, so they are all old listings. First and third link return errors when I try to retire fractional tonnes (as they should) and the Retire button doesn't do anything. But the second link does not show the error message, and I can click Retire. When I try to approve the transaction, this happens:
But I shouldn't even get to that point because the UI should block my attempt to retire a fractional tonne... Also, the error message isn't quite there yet: |
|
good catch, for some reason that middle listing has a default min fill of .001 coming from the subgraph. Not sure how that could have slipped through i.e. you updated that on the 2/15 and it somehow set the minFill to 1 where the previous listing had a minFill of .001, which shouldn't have happened to begin with even though that's kind of weird that shouldn't be an issue as the subgraph should pick up that and use that as the minFill for the frontend |
|
the subgraph wasn't handling minFill amounts for updating listings: PR open in subgraph repo: KlimaDAO/klima-subgraph#119 |
Description
Adjusts default minFill to .001 so new listings will have that default minFill for purchases or retires.
Retires and Purchases use the minFill amount on the subgraph instead of hardcoded version either in the component or a constant.
one minor issue: the format from the subgraph has on decimal place. so it used to show "1" but now will show "1.0". Should that be trimmed?
Related Ticket
Closes #2317
How to Test