-
-
Notifications
You must be signed in to change notification settings - Fork 5.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update graph_accelerometer.py #6003
Conversation
indent error
Please review https://github.com/Klipper3d/klipper/blob/master/docs/CONTRIBUTING.md particularly the signed off by line Thanks |
@dmbutyugin - any thoughts on this bug report? -Kevin |
Thank you for your contribution to Klipper. Unfortunately, a reviewer has not assigned themselves to this GitHub Pull Request. All Pull Requests are reviewed before merging, and a reviewer will need to volunteer. Further information is available at: https://www.klipper3d.org/CONTRIBUTING.html There are some steps that you can take now:
Unfortunately, if a reviewer does not assign themselves to this GitHub Pull Request then it will be automatically closed. If this happens, then it is a good idea to move further discussion to the Klipper Discourse server. Reviewers can reach out on that forum to let you know if they are interested and when they are available. Best regards, PS: I'm just an automated script, not a human being. |
FWIW, the code is somewhat correct. That is, if a user passes a csv file produced by Klipper, it works, there is no mistake there. I suppose the error could arise if the user passes an empty file as an input. A more proper fix would be def parse_log(logname, opts):
with open(logname) as f:
for header in f:
- if not header.startswith('#'):
- break
+ if header.startswith('#'):
+ continue
- if not header.startswith('freq,psd_x,psd_y,psd_z,psd_xyz'):
+ if not header.startswith('freq,psd_x,psd_y,psd_z,psd_xyz'):
+ break
# Raw accelerometer data
return np.loadtxt(logname, comments='#', delimiter=',')
# Power spectral density data or shaper calibration data
opts.error("File %s does not contain raw accelerometer data and therefore "
"is not supported by graph_accelerometer.py script. Please use "
"calibrate_shaper.py script to process it instead." % (logname,)) |
Okay, thanks. Maybe I'm missing something, but the alternative implementation seems to negate the -Kevin |
@KevinOConnor Yes, you are right. So, I sent another PR #6072 with this fix and a few other small improvements. |
This ticket is being closed because the underlying issue is now thought to be resolved. Best regards, PS: I'm just an automated script, not a human being. |
Usage of undeclared local variable 'header' due to missing indentation