Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated bed mesh configuration for Creality Ender 3 S1 and S1 Pro #6219

Merged
merged 1 commit into from
Jul 10, 2023

Conversation

Auxx
Copy link
Contributor

@Auxx Auxx commented May 21, 2023

Existing mesh_min values start probing too far away from the edge.

Additionally mesh_max Y value of 197 is out of bed movement range (197 + bltouch.y_offset = 237.5) and causes Y stepper to overhit, which can potentially damage the printer in the long run.

Signed-off-by: Aleksandr Ivanov aux@hexmode.org

Existing `mesh_min` values start probing too far away from the edge.

Additionally `mesh_max` Y value of 197 is out of bed movement range (197 + `bltouch.y_offset` = 237.5) and causes Y stepper to overhit, which can potentially damage the printer in the long run.
@github-actions
Copy link

github-actions bot commented Jun 4, 2023

Thank you for your contribution to Klipper. Unfortunately, a reviewer has not assigned themselves to this GitHub Pull Request. All Pull Requests are reviewed before merging, and a reviewer will need to volunteer. Further information is available at: https://www.klipper3d.org/CONTRIBUTING.html

There are some steps that you can take now:

  1. Perform a self-review of your Pull Request by following the steps at: https://www.klipper3d.org/CONTRIBUTING.html#what-to-expect-in-a-review
    If you have completed a self-review, be sure to state the results of that self-review explicitly in the Pull Request comments. A reviewer is more likely to participate if the bulk of a review has already been completed.
  2. Consider opening a topic on the Klipper Discourse server to discuss this work. The Discourse server is a good place to discuss development ideas and to engage users interested in testing. Reviewers are more likely to prioritize Pull Requests with an active community of users.
  3. Consider helping out reviewers by reviewing other Klipper Pull Requests. Taking the time to perform a careful and detailed review of others work is appreciated. Regular contributors are more likely to prioritize the contributions of other regular contributors.

Unfortunately, if a reviewer does not assign themselves to this GitHub Pull Request then it will be automatically closed. If this happens, then it is a good idea to move further discussion to the Klipper Discourse server. Reviewers can reach out on that forum to let you know if they are interested and when they are available.

Best regards,
~ Your friendly GitIssueBot

PS: I'm just an automated script, not a human being.

@Auxx
Copy link
Contributor Author

Auxx commented Jun 7, 2023

I reviewed this change according to the steps in the CONTRIBUTING document and everything looks good to me

@KevinOConnor
Copy link
Collaborator

Thanks. @Fisheiyy - do you have any comments on this change?

Separately, commits need to have a signed-off-by line for me to commit them - see: https://www.klipper3d.org/CONTRIBUTING.html

-Kevin

@Fisheiyy
Copy link
Contributor

Fisheiyy commented Jun 8, 2023

Thanks. @Fisheiyy - do you have any comments on this change?

Separately, commits need to have a signed-off-by line for me to commit them - see: https://www.klipper3d.org/CONTRIBUTING.html

-Kevin

Looks fine to me

@github-actions
Copy link

Unfortunately a reviewer has not assigned themselves to this GitHub Pull Request and it is therefore being closed. It is a good idea to move further discussion to the Klipper Discourse server. Reviewers can reach out on that forum to let you know if they are interested and when they are available.

Best regards,
~ Your friendly GitIssueBot

PS: I'm just an automated script, not a human being.

@github-actions github-actions bot closed this Jun 22, 2023
@Sineos
Copy link
Collaborator

Sineos commented Jun 22, 2023

@Auxx - any update?

@Sineos Sineos reopened this Jun 22, 2023
@Auxx
Copy link
Contributor Author

Auxx commented Jun 22, 2023

@Sineos not sure I can provide any updates. I'm not a Klipper developer, not part of the team, I don't have rights to do anything with PR. I can't assign it to myself, I can't approve it, I can't merge it. So it's up to Klipper devs to merge it.

@Bobo1239
Copy link
Contributor

@Auxx You need to add your Signed-off-by: line to the actual commit and not just the pull request description. You can do so using git commit --amend --signoff. Afterwards you can force-push to the branch using git push --force.

@Sineos
Copy link
Collaborator

Sineos commented Jun 23, 2023

Thanks @Bobo1239
@Auxx see @KevinOConnor's comment.

@github-actions
Copy link

github-actions bot commented Jul 7, 2023

Unfortunately a reviewer has not assigned themselves to this GitHub Pull Request and it is therefore being closed. It is a good idea to move further discussion to the Klipper Discourse server. Reviewers can reach out on that forum to let you know if they are interested and when they are available.

Best regards,
~ Your friendly GitIssueBot

PS: I'm just an automated script, not a human being.

@github-actions github-actions bot closed this Jul 7, 2023
@Sineos
Copy link
Collaborator

Sineos commented Jul 7, 2023

@KevinOConnor

  • Sign off is there (at least in the PR text)
  • Reviewed and approved by @Fisheiyy

As a minor change, seems good to go.

@Sineos Sineos reopened this Jul 7, 2023
@KevinOConnor KevinOConnor merged commit ffb5105 into Klipper3d:master Jul 10, 2023
@KevinOConnor
Copy link
Collaborator

Thanks. I merged this PR. Sorry that I didn't see the updated signed-off-by line earlier.

-Kevin

4rianton pushed a commit to 4rianton/klipper that referenced this pull request Jul 10, 2023
… Pro (Klipper3d#6219)

Existing `mesh_min` values start probing too far away from the edge.

Additionally `mesh_max` Y value of 197 is out of bed movement range (197 + `bltouch.y_offset` = 237.5) and causes Y stepper to overhit, which can potentially damage the printer in the long run.

Signed-off-by: Aleksandr Ivanov <aux@hexmode.org>
Lesorin pushed a commit to Lesorin/klipper that referenced this pull request Jul 13, 2023
… Pro (Klipper3d#6219)

Existing `mesh_min` values start probing too far away from the edge.

Additionally `mesh_max` Y value of 197 is out of bed movement range (197 + `bltouch.y_offset` = 237.5) and causes Y stepper to overhit, which can potentially damage the printer in the long run.

Signed-off-by: Aleksandr Ivanov <aux@hexmode.org>
Lesorin pushed a commit to Lesorin/klipper that referenced this pull request Jul 13, 2023
… Pro (Klipper3d#6219)

Existing `mesh_min` values start probing too far away from the edge.

Additionally `mesh_max` Y value of 197 is out of bed movement range (197 + `bltouch.y_offset` = 237.5) and causes Y stepper to overhit, which can potentially damage the printer in the long run.

Signed-off-by: Aleksandr Ivanov <aux@hexmode.org>
rogerlz referenced this pull request in DangerKlippers/danger-klipper Dec 19, 2023
… Pro (#6219)

Existing `mesh_min` values start probing too far away from the edge.

Additionally `mesh_max` Y value of 197 is out of bed movement range (197 + `bltouch.y_offset` = 237.5) and causes Y stepper to overhit, which can potentially damage the printer in the long run.

Signed-off-by: Aleksandr Ivanov <aux@hexmode.org>
@github-actions github-actions bot locked and limited conversation to collaborators Jul 9, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants