-
-
Notifications
You must be signed in to change notification settings - Fork 5.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated bed mesh configuration for Creality Ender 3 S1 and S1 Pro #6219
Updated bed mesh configuration for Creality Ender 3 S1 and S1 Pro #6219
Conversation
Existing `mesh_min` values start probing too far away from the edge. Additionally `mesh_max` Y value of 197 is out of bed movement range (197 + `bltouch.y_offset` = 237.5) and causes Y stepper to overhit, which can potentially damage the printer in the long run.
Thank you for your contribution to Klipper. Unfortunately, a reviewer has not assigned themselves to this GitHub Pull Request. All Pull Requests are reviewed before merging, and a reviewer will need to volunteer. Further information is available at: https://www.klipper3d.org/CONTRIBUTING.html There are some steps that you can take now:
Unfortunately, if a reviewer does not assign themselves to this GitHub Pull Request then it will be automatically closed. If this happens, then it is a good idea to move further discussion to the Klipper Discourse server. Reviewers can reach out on that forum to let you know if they are interested and when they are available. Best regards, PS: I'm just an automated script, not a human being. |
I reviewed this change according to the steps in the CONTRIBUTING document and everything looks good to me |
Thanks. @Fisheiyy - do you have any comments on this change? Separately, commits need to have a signed-off-by line for me to commit them - see: https://www.klipper3d.org/CONTRIBUTING.html -Kevin |
Looks fine to me |
Unfortunately a reviewer has not assigned themselves to this GitHub Pull Request and it is therefore being closed. It is a good idea to move further discussion to the Klipper Discourse server. Reviewers can reach out on that forum to let you know if they are interested and when they are available. Best regards, PS: I'm just an automated script, not a human being. |
@Auxx - any update? |
@Sineos not sure I can provide any updates. I'm not a Klipper developer, not part of the team, I don't have rights to do anything with PR. I can't assign it to myself, I can't approve it, I can't merge it. So it's up to Klipper devs to merge it. |
@Auxx You need to add your |
Thanks @Bobo1239 |
Unfortunately a reviewer has not assigned themselves to this GitHub Pull Request and it is therefore being closed. It is a good idea to move further discussion to the Klipper Discourse server. Reviewers can reach out on that forum to let you know if they are interested and when they are available. Best regards, PS: I'm just an automated script, not a human being. |
As a minor change, seems good to go. |
Thanks. I merged this PR. Sorry that I didn't see the updated signed-off-by line earlier. -Kevin |
… Pro (Klipper3d#6219) Existing `mesh_min` values start probing too far away from the edge. Additionally `mesh_max` Y value of 197 is out of bed movement range (197 + `bltouch.y_offset` = 237.5) and causes Y stepper to overhit, which can potentially damage the printer in the long run. Signed-off-by: Aleksandr Ivanov <aux@hexmode.org>
… Pro (Klipper3d#6219) Existing `mesh_min` values start probing too far away from the edge. Additionally `mesh_max` Y value of 197 is out of bed movement range (197 + `bltouch.y_offset` = 237.5) and causes Y stepper to overhit, which can potentially damage the printer in the long run. Signed-off-by: Aleksandr Ivanov <aux@hexmode.org>
… Pro (Klipper3d#6219) Existing `mesh_min` values start probing too far away from the edge. Additionally `mesh_max` Y value of 197 is out of bed movement range (197 + `bltouch.y_offset` = 237.5) and causes Y stepper to overhit, which can potentially damage the printer in the long run. Signed-off-by: Aleksandr Ivanov <aux@hexmode.org>
… Pro (#6219) Existing `mesh_min` values start probing too far away from the edge. Additionally `mesh_max` Y value of 197 is out of bed movement range (197 + `bltouch.y_offset` = 237.5) and causes Y stepper to overhit, which can potentially damage the printer in the long run. Signed-off-by: Aleksandr Ivanov <aux@hexmode.org>
Existing
mesh_min
values start probing too far away from the edge.Additionally
mesh_max
Y value of 197 is out of bed movement range (197 +bltouch.y_offset
= 237.5) and causes Y stepper to overhit, which can potentially damage the printer in the long run.Signed-off-by: Aleksandr Ivanov aux@hexmode.org