Migracja na v2 GS1 API #3689
Merged
Migracja na v2 GS1 API #3689
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
pwilkin
commented
Apr 17, 2024
pwilkin
commented
- refactoring (uniezależnienie od stałych, zmiana struktur)
|
Stworzyłem prostą apkę, która ułatwia nam testowanie tego API: |
pwilkin
force-pushed
the
piw-gs1v2api
branch
2 times, most recently
from
2aad8af
to
b23da06
Compare
mik-laj
reviewed
Apr 23, 2024
pwilkin
commented
Apr 23, 2024
There was a problem hiding this comment.
Eh. To jest niepoprawione :/
mik-laj
reviewed
Apr 24, 2024
| LOGGER.info("Product missing. Creating a new product.") | ||
| product = Product.objects.create( | ||
| name=result_product.name, | ||
| code=code, | ||
| company=expected_company, | ||
| brand=expected_brand, | ||
| gpc_brick=GPCBrick.objects.get(code=result_product.gpc) if result_product.gpc else None, | ||
| # TODO: co jesli jest wiecej niz jeden GPC? | ||
| gpc_brick=GPCBrick.objects.get(code=result_product.gpc[0].code) if len(result_product.gpc) > 0 else None, |
There was a problem hiding this comment.
Na początek myślę, że my możemy dodać logi z poziomem warning i spróbujemy obserwować, czy ta sytuacja się realnie zdarza.
mik-laj
approved these changes
Apr 24, 2024
pwilkin
added a commit
that referenced
this pull request
Apr 24, 2024
* Ulepszenie komunikatow bledow podczas zbiorczego dodawania (#3729) * Dodaj Pola API Explorer (#3739) * Skasuj marki własne Lidl (#3740) * build(deps): bump the aws group with 2 updates (#3741) Bumps the aws group with 2 updates: [boto3](https://github.com/boto/boto3) and [botocore](https://github.com/boto/botocore). Updates `boto3` from 1.34.89 to 1.34.90 - [Release notes](https://github.com/boto/boto3/releases) - [Changelog](https://github.com/boto/boto3/blob/develop/CHANGELOG.rst) - [Commits](boto/boto3@1.34.89...1.34.90) Updates `botocore` from 1.34.89 to 1.34.90 - [Changelog](https://github.com/boto/botocore/blob/develop/CHANGELOG.rst) - [Commits](boto/botocore@1.34.89...1.34.90) --- updated-dependencies: - dependency-name: boto3 dependency-type: direct:production update-type: version-update:semver-patch dependency-group: aws - dependency-name: botocore dependency-type: direct:production update-type: version-update:semver-patch dependency-group: aws ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * build(deps): bump coverage from 7.4.4 to 7.5.0 (#3743) Bumps [coverage](https://github.com/nedbat/coveragepy) from 7.4.4 to 7.5.0. - [Release notes](https://github.com/nedbat/coveragepy/releases) - [Changelog](https://github.com/nedbat/coveragepy/blob/master/CHANGES.rst) - [Commits](nedbat/coveragepy@7.4.4...7.5.0) --- updated-dependencies: - dependency-name: coverage dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Migracja na v2 GS1 API (#3689) * Migracja na v2 GS1 API + refactoring (uniezależnienie od stałych, zmiana struktur) * Poprawki testów, refactoring wsparcia dla Minio * Usunięcie niewykorzystanych importów * Poprawki formatowania * Poprawki formatowania --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: Kamil Breguła <mik-laj@users.noreply.github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
pwilkin
added a commit
that referenced
this pull request
Apr 24, 2024
* Ulepszenie komunikatow bledow podczas zbiorczego dodawania (#3729) * Dodaj Pola API Explorer (#3739) * Skasuj marki własne Lidl (#3740) * build(deps): bump the aws group with 2 updates (#3741) Bumps the aws group with 2 updates: [boto3](https://github.com/boto/boto3) and [botocore](https://github.com/boto/botocore). Updates `boto3` from 1.34.89 to 1.34.90 - [Release notes](https://github.com/boto/boto3/releases) - [Changelog](https://github.com/boto/boto3/blob/develop/CHANGELOG.rst) - [Commits](boto/boto3@1.34.89...1.34.90) Updates `botocore` from 1.34.89 to 1.34.90 - [Changelog](https://github.com/boto/botocore/blob/develop/CHANGELOG.rst) - [Commits](boto/botocore@1.34.89...1.34.90) --- updated-dependencies: - dependency-name: boto3 dependency-type: direct:production update-type: version-update:semver-patch dependency-group: aws - dependency-name: botocore dependency-type: direct:production update-type: version-update:semver-patch dependency-group: aws ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * build(deps): bump coverage from 7.4.4 to 7.5.0 (#3743) Bumps [coverage](https://github.com/nedbat/coveragepy) from 7.4.4 to 7.5.0. - [Release notes](https://github.com/nedbat/coveragepy/releases) - [Changelog](https://github.com/nedbat/coveragepy/blob/master/CHANGES.rst) - [Commits](nedbat/coveragepy@7.4.4...7.5.0) --- updated-dependencies: - dependency-name: coverage dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Migracja na v2 GS1 API (#3689) * Migracja na v2 GS1 API + refactoring (uniezależnienie od stałych, zmiana struktur) * Poprawki testów, refactoring wsparcia dla Minio * Usunięcie niewykorzystanych importów * Poprawki formatowania * Poprawki formatowania * Brakująca konfiguracja dla test/prod (#3747) --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: Kamil Breguła <mik-laj@users.noreply.github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.