-
Notifications
You must be signed in to change notification settings - Fork 223
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Separate NMEASentence values collection #114
base: master
Are you sure you want to change the base?
Conversation
Could have been used |
My comment was on |
Are you referring to the names of the new methods? I agree there might be better alternatives. |
Just give them a name like |
Thanks for your suggestion, I think this is indeed a better solution. |
Unit tests are now done as well. Anything else to do? |
Awesome work. Would be good for the readme to show an example. |
# Conflicts: # README.md
Done, let me know if there is anything else |
Started to resolve #107.
Separated the value collection into two methods, one for named values (by
fields
) returning a dict and another one without names returning just a list. Also integrated them into__repr__
.Here is how they work currently:
Some points to consider:
Cast known/named values to their actual types e.g. float?This would be a separate issue/PR where probably the parsing of messages would have to be considered.