This repository has been archived by the owner on Nov 27, 2023. It is now read-only.
chore(dependencies): use omni-fetch for builtin proxy support #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
marionebl
commented
Mar 13, 2016
marionebl
commented
- Add omni-fetch as dependency
- Add stub typings for omni-fetch
- Use default export of omni-fetch instead of magic global
- Adds support for HTTP_PROXY, HTTPS_PROXY env variables
|
@marionebl For some reason the test fails stating a missing default export in omni-fetch |
* Add omni-fetch as dependency * Add stub typings for omni-fetch * Use default export of omni-fetch instead of magic global * Adds support for HTTP_PROXY, HTTPS_PROXY env variables
|
@KnisterPeter woops, my bad. See marionebl/omni-fetch@c24cb7b for reference |
| @@ -0,0 +1,3 @@ | |||
| declare module 'omni-fetch' { | |||
| export default fetch; | |||
There was a problem hiding this comment.
Please add the fetch method signature here.
There was a problem hiding this comment.
That boils down to moving the contents of isomorphic-fetch, right? do you want to keep the isomorphic-fetch typings as they are or should I delete them?
There was a problem hiding this comment.
Since pretend isn't using isomorphic fetch directly anymore with this PR please remove isomorphic fetch and add typings for omni-fetch.
KnisterPeter
added a commit
that referenced
this pull request
Mar 13, 2016
chore(dependencies): use omni-fetch for builtin proxy support
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.