Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update readme and setup #66

Merged
merged 2 commits into from
Apr 3, 2020
Merged

Update readme and setup #66

merged 2 commits into from
Apr 3, 2020

Conversation

justaddcoffee
Copy link
Collaborator

  • added a few deps to setup.py
  • added an item in README.rst to run pip install -r requirements.txt (to ensure KGX is installed)

@sonarcloud
Copy link

sonarcloud bot commented Apr 3, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@deepakunni3
Copy link
Member

deepakunni3 commented Apr 3, 2020

@justaddcoffee Why not have KGX be part of setup.py?

That way we can just get rid of requirements.txt and have all dependencies tracked in setup.py

@justaddcoffee
Copy link
Collaborator Author

@justaddcoffee Why not have KGX be part of setup.py?
That way we can just get rid of requirements.txt and have all dependencies tracked in setup.py

I'd be in favor of that, but I think @LucaCappelletti94 encountered some issue when we tried that

@deepakunni3 deepakunni3 merged commit 7927565 into master Apr 3, 2020
@deepakunni3
Copy link
Member

Yes, now I remember. Okay, we can remove requirements.txt later

@justaddcoffee justaddcoffee deleted the update_README_and_setup branch April 3, 2020 23:18
@justaddcoffee
Copy link
Collaborator Author

thanks @deepakunni3 !

@LucaCappelletti94
Copy link
Collaborator

Hi @deepakunni3! I thought that KGX was not available as a python package on pypi hence it required a direct installation from the repository, which we could not manage to integrate with the setup.py. Is there a python package? Or did you manage to integrate the repository? Or there's a third way?

I would love to learn how to do it! Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants