Introduce StorageFailure and FileNotFound exceptions #517
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicolasmure
approved these changes
Jul 7, 2017
| */ | ||
| class StorageFailure extends \RuntimeException implements Exception | ||
| { | ||
| public static function unexpectedFailure($action, $args, \Exception $previous = null) |
There was a problem hiding this comment.
Can you type hint the $args parameter (and also add a doc block) please ?
akerouanton
force-pushed
the
1.x-fs-exceptions
branch
from
70f65ec
to
5a55c46
Compare
|
I added the missing phpdoc and typehint ;) |
12 tasks
added 4 commits
July 7, 2017 16:07
akerouanton
force-pushed
the
1.x-fs-exceptions
branch
from
5a55c46
to
faa268b
Compare
nicolasmure
approved these changes
Jul 7, 2017
|
Thank you ! 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The main reason: it's currently impossible to know what's going wrong when one of the method fails. So rather than bad return values, I updated the Adapter API to throw exceptions.
So, this PR introduces two exceptions to be used by adapters:
Gaufrette\Exception\StorageFailureandGaufrette\Exception\FileNotFound. I implemented only AwsS3 for now and Filesystem methods would benefit from such overhauling (something likeFilesystemException). But this patch has been done mostly to demonstrates what we could do to enhance the current API, more will come if this one is accepted.See #497.