refacto: spec types #701
Closed
refacto: spec types #701
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
muchafm
force-pushed
the
refacto/spec-types
branch
2 times, most recently
from
7614e68
to
1577552
Compare
muchafm
force-pushed
the
refacto/spec-types
branch
from
1577552
to
f0fcab2
Compare
Zusoy
approved these changes
May 12, 2023
KevinArtus
suggested changes
May 25, 2023
| @@ -13,10 +13,10 @@ | |||
| class AzureBlobStorageTest extends FunctionalTestCase | |||
| { | |||
| /** @var string Name of the Azure container used */ | |||
| private $container; | |||
| private string $container; | |||
|
|
|||
| /** @var AzureBlobStorage */ | |||
| @@ -13,10 +13,10 @@ | |||
| class AzureBlobStorageTest extends FunctionalTestCase | |||
| { | |||
| /** @var string Name of the Azure container used */ | |||
There was a problem hiding this comment.
Suggested change
| /** @var string Name of the Azure container used */ | |
| /** Name of the Azure container used */ |
muchafm
force-pushed
the
feat/add-type-adapter
branch
from
09b0fdc
to
8bd80cc
Compare
muchafm
force-pushed
the
feat/add-type-adapter
branch
from
8bd80cc
to
f16ad45
Compare
KevinArtus
approved these changes
May 26, 2023
PedroTroller
requested changes
May 26, 2023
| @@ -30,17 +30,17 @@ function extension_loaded($name) | |||
| return $extensionLoaded; | |||
| } | |||
|
|
|||
| function opendir($url) | |||
There was a problem hiding this comment.
See rewrited function: https://www.php.net/manual/en/function.opendir.php
| { | ||
| return true; | ||
| } | ||
|
|
||
| function apc_fetch($path) |
There was a problem hiding this comment.
| { | ||
| return sprintf('%s content', $path); | ||
| } | ||
|
|
||
| function apc_store($path, $content, $ttl) |
There was a problem hiding this comment.
| @@ -58,7 +58,7 @@ function apc_delete($path) | |||
| return true; | |||
| } | |||
|
|
|||
| function apc_exists($path) | |||
There was a problem hiding this comment.
muchafm
force-pushed
the
refacto/spec-types
branch
from
2ac645e
to
79645d2
Compare
PedroTroller
approved these changes
Jun 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.