Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Modernize Code base #178

Merged
merged 1 commit into from
Jul 31, 2023
Merged

Modernize Code base #178

merged 1 commit into from
Jul 31, 2023

Conversation

kbond
Copy link
Contributor

@kbond kbond commented Jul 26, 2023 •
edited
Loading

The commits explain what was done. Some changes are opinionated and I have no problem removing/changing.

Fixes #179.
Fixes #167.

@kbond
Copy link
Contributor Author

kbond commented Jul 26, 2023 •
edited
Loading

Regarding 0e7b957 (add time_diff twig filter and deprecate ago), I'm guessing time_diff was not used originally because it interfered with time_diff from the deprecated twig/extensions. I think enough time has passed now.

I deprecated ago because it is a bit of a misnomer as it works with future dates as well but don't have a strong opinion here.

weaverryan
weaverryan reviewed Jul 31, 2023
View reviewed changes
config/templating.php Outdated Show resolved Hide resolved
@weaverryan weaverryan mentioned this pull request Jul 31, 2023
Closed
@kbond kbond force-pushed the modernize branch 2 times, most recently from db1dba7 to e8b6469 Compare July 31, 2023 15:42
@weaverryan
Copy link
Collaborator

Thanks Kevin!

@weaverryan weaverryan merged commit d543bce into KnpLabs:master Jul 31, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@weaverryan weaverryan weaverryan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

getDiffMessage is not used
2 participants
@kbond @weaverryan