Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updated duration translation for NB #184

Merged
merged 1 commit into from
Jul 31, 2023
Merged

Updated duration translation for NB #184

merged 1 commit into from
Jul 31, 2023

Conversation

ahaaje
Copy link
Contributor

@ahaaje ahaaje commented Jul 31, 2023

This adds the #181 duration translation for "Norsk bokmål" NB locale

kbond
kbond suggested changes Jul 31, 2023
View reviewed changes
Copy link
Contributor

@kbond kbond left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for working on this @ahaaje

@kbond kbond mentioned this pull request Jul 31, 2023
Open
41 tasks
@weaverryan
Copy link
Collaborator

Thanks @ahaaje!

@weaverryan weaverryan merged commit ea3612e into KnpLabs:main Jul 31, 2023
13 checks passed
@kbond
Copy link
Contributor

kbond commented Jul 31, 2023

@ahaaje, is it expected that duration.day and duration.none are missing?

@weaverryan
Copy link
Collaborator

Oh yea, I just noticed that also!

@kbond
Copy link
Contributor

kbond commented Jul 31, 2023

I think it's because the snippet in #181 has an unfortunate scroll :)

@ahaaje
Copy link
Contributor Author

ahaaje commented Jul 31, 2023

Yes, I did not see them there. I will update

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kbond kbond kbond requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ahaaje @weaverryan @kbond