Skip to content

Add OutsideCollaborators api #925

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 5, 2020
Merged

Add OutsideCollaborators api #925

merged 1 commit into from
Oct 5, 2020

Conversation

Matth--
Copy link
Contributor

@Matth-- Matth-- commented Oct 5, 2020

acrobat
acrobat requested changes Oct 5, 2020
View reviewed changes
Copy link
Collaborator

@acrobat acrobat left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR @Matth--! Can you check my comment and apply the styleci fixes? Thanks!

@Matth--
Copy link
Contributor Author

Matth-- commented Oct 5, 2020

Applied the generated style ci diff and implemented the suggestion.

Thanks!

@Matth-- Matth-- requested a review from acrobat October 5, 2020 18:31
@acrobat acrobat merged commit 8de302c into KnpLabs:2.x Oct 5, 2020
@acrobat
Copy link
Collaborator

acrobat commented Oct 5, 2020

Thanks @Matth--! And congrats on your first contribution! 🎉

@Matth-- Matth-- deleted the feature/outside-collaborators branch October 5, 2020 19:12
@dependabot dependabot bot mentioned this pull request Mar 15, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@acrobat acrobat acrobat approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Matth-- @acrobat