Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add sync a fork branch with the upstream repository #1084

Merged
merged 5 commits into from
Oct 24, 2022
Merged

Add sync a fork branch with the upstream repository #1084

merged 5 commits into from
Oct 24, 2022

Conversation

DAGpro
Copy link
Contributor

@DAGpro DAGpro commented Sep 18, 2022

Q A
New feature? ✔️
Fixed issues #1083

iBotPeaches
iBotPeaches reviewed Sep 19, 2022
View reviewed changes
Copy link
Contributor

@iBotPeaches iBotPeaches left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@DAGpro - You'll want to fix CI issues here. Looks like a basic lint issue so the test suite can move forward.

lib/Github/Api/Repo.php Outdated Show resolved Hide resolved
lib/Github/Api/Repo.php Outdated Show resolved Hide resolved
@DAGpro DAGpro changed the title Add sync a fork branch with the upstream repository feature #1083 Add sync a fork branch with the upstream repository Sep 19, 2022
@DAGpro DAGpro changed the title feature #1083 Add sync a fork branch with the upstream repository Add sync a fork branch with the upstream repository Sep 19, 2022
@DAGpro
Copy link
Contributor Author

DAGpro commented Sep 19, 2022

@DAGpro - You'll want to fix CI issues here. Looks like a basic lint issue so the test suite can move forward.

The commit message must mention the issue?

@iBotPeaches
Copy link
Contributor

@DAGpro - You'll want to fix CI issues here. Looks like a basic lint issue so the test suite can move forward.

The commit message must mention the issue?

The squash merge normally renames the commit anyway, so don't think that important. You still have some linting issues btw - https://github.styleci.io/analyses/xgBanO

@DAGpro DAGpro force-pushed the sync-upstream branch 2 times, most recently from 53a822f to 369de6b Compare September 19, 2022 17:22
@DAGpro
Copy link
Contributor Author

DAGpro commented Sep 20, 2022

@iBotPeaches now no problem to merge?

acrobat
acrobat requested changes Oct 23, 2022
View reviewed changes
Copy link
Collaborator

@acrobat acrobat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR @DAGpro!

Can you also add a test for this method, see: https://github.com/KnpLabs/php-github-api/blob/master/test/Github/Tests/Api/RepoTest.php. And add a docs entry so it is documented, see https://github.com/KnpLabs/php-github-api/blob/master/doc/repos.md

lib/Github/Api/Repo.php Outdated Show resolved Hide resolved
@acrobat acrobat linked an issue Oct 23, 2022 that may be closed by this pull request
Sync a fork branch with the upstream repository #1083
Closed
acrobat
acrobat requested changes Oct 24, 2022
View reviewed changes
Copy link
Collaborator

@acrobat acrobat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One small remark and then it's ready to merge!

lib/Github/Api/Repo.php Outdated Show resolved Hide resolved
@acrobat acrobat merged commit f1cb6b6 into KnpLabs:master Oct 24, 2022
@acrobat
Copy link
Collaborator

acrobat commented Oct 24, 2022

Thanks @DAGpro! And congrats on your first contribution! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iBotPeaches iBotPeaches iBotPeaches left review comments

@acrobat acrobat acrobat approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Sync a fork branch with the upstream repository
3 participants
@DAGpro @iBotPeaches @acrobat