Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(installation): refactor provider path to infrastructure #65

Merged
merged 4 commits into from
Jan 28, 2023
Merged

Conversation

holiq
Copy link
Member

@holiq holiq commented Jan 27, 2023

No description provided.

@holiq holiq self-assigned this Jan 27, 2023
@what-the-diff
Copy link

what-the-diff bot commented Jan 27, 2023

  • Add option --skip-refactor to skip refactoring app path
  • Refactor App\Providers namespace and directory structure into Infrastructure/Laravel/Providers
  • Update config file with new namespace for providers in infrastructure layer
  • Update all files inside Providers folder with the new namespace of Infrastructure\Laravel\Provider

Copy link
Member

@pemudakoding pemudakoding left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please can make test for the providers files already moved and deleted from app/

{
if (! $this->option('skip-refactor')) {
$filesystem = new Filesystem;
$providerPath = app_path(path: 'Providers');
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

since this variable isn't get use in anywhere you can put to the argument directly

@pemudakoding pemudakoding added the bug Something isn't working label Jan 28, 2023
@pemudakoding pemudakoding merged commit e011665 into KoalaFacade:main Jan 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants