Send default response to report #10
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refer Koenkk/zigbee2mqtt#1722
This patch works for me but it would be great if others could review and also confirm.
It sends a default response back whenever the coordinator receives an attribute report thereby heading off repeated sending of the report. I figured generating the response in zigbee-herdsman was easier than passing it up to zigbee2mqtt and back for what is effectively just an ack.
Here's the sort of traffic I see without the default response patch.
and here is the sort of traffic I see with this patch. The sequence number of the response have to match the report to prevent the repeated report messages.
