Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Optimize Home Assistant discovery #22701

Merged
merged 7 commits into from
May 21, 2024
Merged

fix: Optimize Home Assistant discovery #22701

merged 7 commits into from
May 21, 2024

Conversation

Koenkk
Copy link
Owner

@Koenkk Koenkk commented May 19, 2024 •
edited
Loading

This PR optimises the HA discovery performance:

  • Don't publish discovery messages that are already retained by the MQTT broker
  • Prevent receiving of discovery messages published by Z2M by unsubscribing from the topic before discovery
  • Prevent a call to getConfigs for every received discovery message

TODO:

  • Fix TODOs
  • Test on own prod network

Should improve the situation of #20648

@Koenkk Koenkk marked this pull request as draft May 19, 2024 21:39
@Koenkk Koenkk marked this pull request as ready for review May 21, 2024 18:31
@Koenkk Koenkk merged commit ef68cc3 into dev May 21, 2024
21 checks passed
@Koenkk Koenkk deleted the fix/optimize-ha-discovery branch May 21, 2024 18:53
This was referenced May 21, 2024
Closed
Closed
This was referenced Jun 1, 2024
Closed
Merged
This was referenced Jun 8, 2024
Open
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@Koenkk