Do not send any event to disabled devices #23058
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As z2m requires a restart for enable/disable to be effective, we don't need to handle changes at runtime (stop events etc)
|
Thanks! |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some devices require active polling that is setup using onEvent triggers
When the device is disabled we should stop polling them to avoid unnecessary traffic, errors in logs etc
Following up Koenkk/zigbee-herdsman-converters#7619, rather than implement the test on a device level, handle it at Z2M level, avoiding the call for disabled devices
As z2m requires a restart for enable/disable to be effective, we don't need to handle changes at runtime (stop events etc)