Implement support for OGC API Features #25
Conversation
...orter-core/src/main/java/org/n52/kommonitor/importer/io/datasource/APIFeaturesRetriever.java
Outdated
Show resolved
Hide resolved
...orter-core/src/main/java/org/n52/kommonitor/importer/io/datasource/APIFeaturesRetriever.java
Outdated
Show resolved
Hide resolved
...-importer-core/src/main/java/org/n52/kommonitor/importer/converter/APIFeaturesConverter.java
Outdated
Show resolved
Hide resolved
...orter-core/src/main/java/org/n52/kommonitor/importer/io/datasource/APIFeaturesRetriever.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Better remove this POJO. It may cause interferences with org.springframework.http.ResponseEntity.
There was a problem hiding this comment.
Is there a way to exclude this file from auto-generation? I don't like the workflow of manually deleting the file everytime we regenerate the api-specs.
If this is not trivially possible i would just leave the file there. During development you will very quickly notice that you imported the wrong ResponseEntity as it does not provide the same methods and is a totally different type of class.
There was a problem hiding this comment.
Yes. Just add the class name to the .openapi-generator-ignore file: https://github.com/OpenAPITools/openapi-generator/blob/master/docs/customization.md#ignore-file-format
There was a problem hiding this comment.
Besides that, I noticed that the Unit Test fails which leads to a failing build.
apparently "simplification" is taken very literally and geometries are reduced to basic squares or null geometries
...orter-core/src/main/java/org/n52/kommonitor/importer/io/datasource/APIFeaturesRetriever.java
Outdated
Show resolved
Hide resolved
depends on: