Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: flixpatrol_popular limit is ignored #506

Closed
rfletcher opened this issue Dec 13, 2021 · 2 comments · Fixed by #514
Closed

Bug: flixpatrol_popular limit is ignored #506

rfletcher opened this issue Dec 13, 2021 · 2 comments · Fixed by #514
Assignees
Labels
bug Bug is with Plex Meta Manager status:added-to-develop Feature Request or Bug Fix is in Develop

Comments

@rfletcher
Copy link

Describe the Bug

The flixpatrol_popular builder seems to ignore its limit attribute.

Relevant Collection Config

collections:
  Trending Movies:
    flixpatrol_popular:
      source:      movie_db
      time_window: today
      limit:       10

Plex Meta Manager Info

PMM v1.13.3

Logs

The configured limit is reflected in the log, but the builder still pulls the entire list of (100) movies and tries to add them all to the collection.:

...
[builder.py:1213]   [DEBUG] |                                                                                                    |
[builder.py:1214]   [DEBUG] | Builder: flixpatrol_popular: {'source': 'movie_db', 'time_window': 'today', 'limit': 10}           |
[builder.py:1215]   [INFO]  |                                                                                                    |
[flixpatrol.py:122] [INFO]  | Processing FlixPatrol Popular:                                                                     |
[flixpatrol.py:123] [INFO]  |      Source: Movie Db                                                                                  |
[flixpatrol.py:124] [INFO]  |      Time Window: Today                                                                                |
[flixpatrol.py:125] [INFO]  |      Limit: 10                                                                                         |
[flixpatrol.py:156] [INFO]  | Processed 100 TMDb IDs                                                                             |
[builder.py:1249]   [DEBUG] |                                                                                                    |
[builder.py:1250]   [DEBUG] | 100 IDs Found: [(438631, 'tmdb'), (512195, 'tmdb'), (522402, 'tmdb'), (580489, 'tmdb'), (617653, 'tmdb'), (566525, 'tmdb'), (370172, 'tmdb'), (524434, 'tmdb'), (576845, 'tmdb'), (429617, 'tmdb'), (550988, 'tmdb'), (802217, 'tmdb'), (645886, 'tmdb'), (634649, 'tmdb'), (568124, 'tmdb'), (585245, 'tmdb'), (482321, 'tmdb'), (460458, 'tmdb'), (615666, 'tmdb'), (810873, 'tmdb'), (675445, 'tmdb'), (771, 'tmdb'), (646380, 'tmdb'), (1930, 'tmdb'), (315635, 'tmdb'), (5825, 'tmdb'), (618162, 'tmdb'), (654974, 'tmdb'), (671, 'tmdb'), (451048, 'tmdb'), (635731, 'tmdb'), (508943, 'tmdb'), (644495, 'tmdb'), (305312, 'tmdb'), (600583, 'tmdb'), (656276, 'tmdb'), (290098, 'tmdb'), (519834, 'tmdb'), (425909, 'tmdb'), (283351, 'tmdb'), (285026, 'tmdb'), (11395, 'tmdb'), (390293, 'tmdb'), (589761, 'tmdb'), (537116, 'tmdb'), (624860, 'tmdb'), (770254, 'tmdb'), (603, 'tmdb'), (516329, 'tmdb'), (758879, 'tmdb'), (609972, 'tmdb'), (877183, 'tmdb'), (893871, 'tmdb'), (762433, 'tmdb'), (436969, 'tmdb'), (299536, 'tmdb'), (774607, 'tmdb'), (106646, 'tmdb'), (885110, 'tmdb'), (299534, 'tmdb'), (718633, 'tmdb'), (635302, 'tmdb'), (321612, 'tmdb'), (335983, 'tmdb'), (776821, 'tmdb'), (511809, 'tmdb'), (843241, 'tmdb'), (330457, 'tmdb'), (718032, 'tmdb'), (763164, 'tmdb'), (360920, 'tmdb'), (716612, 'tmdb'), (338964, 'tmdb'), (876262, 'tmdb'), (324857, 'tmdb'), (614917, 'tmdb'), (876716, 'tmdb'), (846542, 'tmdb'), (630240, 'tmdb'), (597208, 'tmdb'), (777270, 'tmdb'), (271110, 'tmdb'), (896221, 'tmdb'), (496243, 'tmdb'), (785545, 'tmdb'), (277834, 'tmdb'), (895001, 'tmdb'), (664574, 'tmdb'), (109445, 'tmdb'), (245891, 'tmdb'), (542178, 'tmdb'), (744275, 'tmdb'), (734265, 'tmdb'), (459151, 'tmdb'), (284053, 'tmdb'), (855400, 'tmdb'), (768447, 'tmdb'), (135397, 'tmdb'), (550, 'tmdb'), (68721, 'tmdb')] |
[builder.py:1213]   [DEBUG] |
...
@rfletcher rfletcher added bug Bug is with Plex Meta Manager status:not-yet-viewed I haven't reviewed the Feature or Bug yet labels Dec 13, 2021
meisnate12 added a commit that referenced this issue Dec 15, 2021
@meisnate12 meisnate12 added status:added-to-develop Feature Request or Bug Fix is in Develop and removed status:not-yet-viewed I haven't reviewed the Feature or Bug yet labels Dec 15, 2021
@meisnate12
Copy link
Member

should be fixed in develop

@meisnate12 meisnate12 mentioned this issue Dec 18, 2021
@meisnate12 meisnate12 reopened this Dec 18, 2021
@meisnate12
Copy link
Member

I'll close it once I push the changes to master

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Bug is with Plex Meta Manager status:added-to-develop Feature Request or Bug Fix is in Develop
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants