Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request: Allow Custom Github Base #630

Closed
GD-L opened this issue Jan 19, 2022 · 4 comments · Fixed by #652
Closed

Feature Request: Allow Custom Github Base #630

GD-L opened this issue Jan 19, 2022 · 4 comments · Fixed by #652
Assignees
Labels
enhancement New feature or request status:added-to-develop Feature Request or Bug Fix is in Develop

Comments

@GD-L
Copy link

GD-L commented Jan 19, 2022

Per Line: https://github.com/meisnate12/Plex-Meta-Manager/blob/38818e8d4ee0aec59dc91a714e934648a07b1993/modules/meta.py#L10
Allowing users to input their own GitHub base and/or multiple bases from which to pull.

@GD-L GD-L added enhancement New feature or request status:not-yet-viewed I haven't reviewed the Feature or Bug yet labels Jan 19, 2022
@meisnate12
Copy link
Member

You can just use the raw url to any repo if you want to do this right now but I'll consider a custom repo tag of some kind

@GD-L
Copy link
Author

GD-L commented Jan 19, 2022

Valid point. I may make a pull to the Wiki to make it clearer that the git points to ../Plex-Meta-Manager-Configs/ repo, or I may've missed that.

I'm not super good at python but my thinking is:
parser.add_argument("-g", "--git", dest="git", help="GitHub Repo", default="https://github.com/meisnate12/Plex-Meta-Manager-Configs, type=str)
gitrepo= get_arg("PMM_REPO", args.git, arg_bool=True)

But, (personally) I'm not sure how to get meta.py to pass through the argument from plex_meta_manager.py without moving that module

meisnate12 added a commit that referenced this issue Jan 24, 2022
@meisnate12 meisnate12 added status:added-to-develop Feature Request or Bug Fix is in Develop and removed status:not-yet-viewed I haven't reviewed the Feature or Bug yet labels Jan 24, 2022
@meisnate12
Copy link
Member

meisnate12 commented Jan 24, 2022

you can now specify custom_repo in the global settings and then you can specify repo when defining metadata files

so if
custom_repo: https://raw.githubusercontent.com/meisnate12/Plex-Meta-Manager-Configs/master/
and the metadata file is defined as repo: meisnate12/Movies
it will look for
https://raw.githubusercontent.com/meisnate12/Plex-Meta-Manager-Configs/master/meisnate12/Movies.yml

@nwithan8
Copy link

nwithan8 commented Feb 10, 2022

you can now specify custom_repo in the global settings and then you can specify repo when defining metadata files

so if custom_repo: https://raw.githubusercontent.com/meisnate12/Plex-Meta-Manager-Configs/master/ and the metadata file is defined as repo: meisnate12/Movies it will look for https://raw.githubusercontent.com/meisnate12/Plex-Meta-Manager-Configs/master/meisnate12/Movies.yml

RE: this, the docs still mention that this is for "Playlist Files" in the Metadata File section. Figured it was a typo, happy to fork and PR if needed, just wanted to confirm that this is indeed an error first.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request status:added-to-develop Feature Request or Bug Fix is in Develop
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants