Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cache ETH/ERC20 balance on portfolio calls to avoid displaying invalid amount in case of errors. #82

Closed
artemii235 opened this issue Jun 20, 2018 · 4 comments

Comments

@artemii235
Copy link
Member

No description provided.

artemii235 added a commit that referenced this issue Jun 22, 2018
#80 #81 #82 #84 ERC20 decimals on enable. ETH address validation. Portfolio ETH/ERC20 balance cache on error. ETOMIC electrum mode faucet request fix.
@artemii235
Copy link
Member Author

@lukechilds https://github.com/artemii235/SuperNET/releases/tag/v1.0.268 - release is published, please test it.

@lukechilds
Copy link

This works, if I turn off my internet connection, the next portfolio requests show the old balance.

However the first portfolio request after losing connectivity seems to take a very long time to resolve (~1.3mins).

This is a big issue due to the fact that marketmaker is single threaded so it completely blocks everything and makes the app unusable for over a minute.

It could possibly be caused by losing network while a request is happening.

Is this just due to an internal timeout? If so do you think you could decrease it?

@lukechilds
Copy link

This issue is resolved so I'll close it, will open a new issues regarding blocking the main thread.

@lukechilds
Copy link

lukechilds commented Jun 22, 2018

Blocking issue tracked here: #86

You can close this issue as it's resolved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants