[r2r] Zcoin native mode support integration & multi lightwalletd servers support #1438
Conversation
# Conflicts: # mm2src/coins/z_coin/z_coin_errors.rs
# Conflicts: # mm2src/coins/z_coin/z_rpc.rs
laruh
changed the title
laruh
changed the title
laruh
changed the title
laruh
changed the title
| let compact_tx = TonicCompactTx { | ||
| index: tx_id as u64, | ||
| hash: hash_tx_vec, | ||
| fee: 0, |
There was a problem hiding this comment.
There is note for fee in CompactTx The transaction fee: present if server can provide. In the case of a stateless server and a transaction with transparent inputs, this will be unset because the calculation requires reference to prior transactions.
The light mode all the time puts fee: 0 for compact transactions.
So, yes, it will be 0.
| drop_mutability!(hash); | ||
| drop_mutability!(prev_hash); | ||
| drop_mutability!(compact_txs); |
There was a problem hiding this comment.
I think there is no need to drop the mutability of the variables that will be moved immediately.
There was a problem hiding this comment.
On the one hand, I agree with you, because that is how rust works.
On the other hand, using that macros we can avoid future bugs or ub (reference to this comment). We can just be sure, that everything will be ok.
In addition drop_mutability! is zero cost, so its only about readability issue.
We could just have the project rule "if you don't need the mutable variable - drop the mutability".
mm2src/coins/z_coin/z_rpc.rs
Outdated
| let db = | ||
| WalletDb::for_path(wallet_db_path, consensus_params).map_to_mm(ZcoinClientInitError::WalletDbInitFailure)?; | ||
| run_optimization_pragmas(db.sql_conn()).map_to_mm(ZcoinClientInitError::WalletDbInitFailure)?; | ||
| init_wallet_db(&db).map_to_mm(ZcoinClientInitError::WalletDbInitFailure)?; | ||
| if db.get_extended_full_viewing_keys()?.is_empty() { | ||
| init_accounts_table(&db, &[evk])?; | ||
| if let Some(check_point) = check_point_block { | ||
| init_blocks_table( | ||
| &db, | ||
| BlockHeight::from_u32(check_point.height), | ||
| BlockHash(check_point.hash.0), | ||
| check_point.time, | ||
| &check_point.sapling_tree.0, | ||
| )?; | ||
| } | ||
| } | ||
| Ok(db) |
There was a problem hiding this comment.
As I can see, this function body has been moved from init_light_client, where it was wrapped into async_blocking({}).
Do we need to use async_blocking({}) in this function as well?
There was a problem hiding this comment.
Oh, I missed it during refactoring. Yeap, it should be in create_wallet_db function, because async_blocking uses spawn_blocking from tokio.
Done.
laruh
changed the title
…d from check_watch_for_tx()
laruh
changed the title
related to #927
lightwalletd ports grpcs/http:
443/8000
1443/8002
2443/8003