-
Notifications
You must be signed in to change notification settings - Fork 98
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
allow -ac_private for the ZOMBIE test chain #615
Conversation
Better solution for the issues mentioned in #589 .
Better solution for the issue(s) mentioned in KomodoPlatform/komodo#589 . - KomodoPlatform/komodo#615
Wouldn't the "better solution" be to drop the concept? We don't seem to support the opposite concept (coding "if you want public only, you cannot have it because there's no reason to just not use KMD"). |
If you would like to discuss the "concept" itself, please create a separate issue. Your comment is not related to this pull request, which is solely intended to add permission for the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Confirmed no issues with launch for KMD, PIRATE or ZOMBIE, and shutdown when attempting launch of private chain with tickers not in the allow list.
Yes, I'll get right on creating a separate issue which addresses this pull request which addresses an issue that isn't this pull request so that that not-new issue (which addresses this pull request which addresses an issue that isn't this pull request) can sit ignored for years and then quietly closed; that's a much better solution than discussing the merits of this pull request inside the conversation mechanism of this pull request. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
I was able to run ZOMBIE node with this fix,
this also fixes an issue when ac_name was an unsupported private chain we got a misleading 'error in HDD data' msg
Better solution for the issues mentioned in #589 .