Fixed the issue that caused CMake to look for non-existent path after being installed #213
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
axsaucedo
requested changes
May 3, 2021
src/CMakeLists.txt
Outdated
| # To build the Android example without installing Vulkan Kompute, | ||
| # We need to specify the paths for include directories directly | ||
| # NOTE: This is a temporary fix | ||
| if(KOMPUTE_OPT_ANDOID_BUILD) |
There was a problem hiding this comment.
Just noticed there is a typo on this flag, but it seems it's correct - I think for now may be worth just removing for now and we can add this guard as separate commit.
|
Done |
|
Nice one - lgtm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
$<INSTALL_INTERFACE:single_include>insrc/CMakeLists.txtcauses CMake to look for a non-existent(#212 ), this PR gets back to the approach that was used before, and also temporarily adding the existent approach to Android because apparently, it faces issues when include directories aren't included explicitly.