fix(semantics): fix incorrect type checking that prevented `IpAddr in #82
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chronolaw
reviewed
Jul 4, 2023
chronolaw
reviewed
Jul 4, 2023
|
We will test this fix in Kong/kong#11071, before that please do not merge it into master. |
dndx
force-pushed
the
fix/ipaddr_check
branch
2 times, most recently
from
c40add8
to
939fda9
Compare
3 tasks
IpCidr` matchings
IpAddr, added more test cases for `==` and `in`, `not in`
chronolaw
approved these changes
Jul 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IpCidr` matchings
https://konghq.atlassian.net/browse/KAG-1846