Helm3 CRDs #10
Merged
Helm3 CRDs #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hbagdi
requested changes
Jan 22, 2020
There was a problem hiding this comment.
Can we please update the docs in the README to document that installCRDs will not work with Helm 3?
This is similar to how https://github.com/helm/charts/pull/18721/files updates the documentation.
| metadata: | ||
| name: kongplugins.configuration.konghq.com | ||
| labels: | ||
| app.kubernetes.io/name: name |
There was a problem hiding this comment.
Please remove this label from all the resources.
There was a problem hiding this comment.
uggh, I meant to have the value be kong. Should I just remove the entire label or replace name with kong?
There was a problem hiding this comment.
Let's just remove it because it doesn't provide any value as far as I can see.
|
@hbagdi good call - will do |
hbagdi
approved these changes
Jan 23, 2020
|
Thank you for your contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This provides support for Helm 3 CRDs. In Helm 3, CRDs are defined in the new
crdsfolder: https://helm.sh/docs/topics/chart_best_practices/custom_resource_definitions/.This solves an issue of using Kong as a dependency (subchart) of an umbrella chart and using the CRD (for example KongPlugin). This is currently not possible (or at the very least very challenging) in Helm 2 charts; see here: (helm/helm#2994).
I have followed the strategy of this project for example helm/charts#18721 to ensure backward compatibility for helm2 by copying over the resource definitions to the templates directory as well. (See this as well: helm/charts#19008)
Note that the new
crdsdirectory does not evaluate templates, and so values must be hard coded. Again, I followed the path outlined in the links above.