Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kong: Add flag to disable CRD check for mass server-side apply #1077

Merged
merged 1 commit into from
Oct 11, 2024

Conversation

jcpunk
Copy link
Contributor

@jcpunk jcpunk commented Jun 4, 2024

What this PR does / why we need it:

When using a mass deployment tool (like kluctl) helm may be rendered locally before being submitted. In this two step process the CRDs are not yet deployed and thus the chart fails to render. The ability to pre-render the templates simplifies generation of the manifests for offline review or pass through kustomiz. This sort of gitops workflow does all the renders in one step for review, then the apply in another step once the differences are approved.

Which issue this PR fixes

(optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged)

  • fixes #

Special notes for your reviewer:

Checklist

[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

  • PR is based off the current tip of the main branch.
  • Changes are documented under the "Unreleased" header in CHANGELOG.md
  • New or modified sections of values.yaml are documented in the README.md
  • Commits follow the Kong commit message guidelines

@jcpunk jcpunk requested a review from a team as a code owner June 4, 2024 14:52
@CLAassistant
Copy link

CLAassistant commented Jun 4, 2024

CLA assistant check
All committers have signed the CLA.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

Copy link
Member

@tao12345666333 tao12345666333 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contributions.
I think this is valuable.

@tao12345666333 tao12345666333 requested a review from a team June 24, 2024 23:23
@randmonkey randmonkey merged commit 0b3ad20 into Kong:main Oct 11, 2024
36 checks passed
@jcpunk jcpunk deleted the nocheck-api branch October 11, 2024 13:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants