Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Add compatibility configuration for konnect.runtimeGroupID #1109

Merged
merged 1 commit into from
Jul 25, 2024

Conversation

tao12345666333
Copy link
Member

What this PR does / why we need it:

konnect.runtimeGroupID is still used as the configuration guide in Konnect. After communicating with team-konnect, we believe that directly replacing konnect.runtimeGroupID with konnect.controlPlaneID may cause disruptive changes. Therefore, it is necessary to add compatibility configurations in Charts to avoid disrupting user deployments.

Which issue this PR fixes

(optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged)

Special notes for your reviewer:

Checklist

[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

  • PR is based off the current tip of the main branch.
  • Changes are documented under the "Unreleased" header in CHANGELOG.md
  • New or modified sections of values.yaml are documented in the README.md
  • Commits follow the Kong commit message guidelines

Signed-off-by: Jintao Zhang <zhangjintao9020@gmail.com>
@tao12345666333 tao12345666333 requested a review from a team as a code owner July 24, 2024 07:16
@tao12345666333 tao12345666333 self-assigned this Jul 24, 2024
charts/kong/README.md Show resolved Hide resolved
charts/kong/values.yaml Show resolved Hide resolved
@tao12345666333 tao12345666333 merged commit 44d3a9c into main Jul 25, 2024
33 checks passed
@tao12345666333 tao12345666333 deleted the add-runtimeGroupID-back branch July 25, 2024 09:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add compatibility configuration for konnect.runtimeGroupID
2 participants