Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

core(docs): add info about using host network for DaemonSet #918

Merged
merged 1 commit into from
Oct 30, 2023

Conversation

programmer04
Copy link
Member

@programmer04 programmer04 commented Oct 30, 2023

What this PR does / why we need it:

Add more description for deploying KIC as DaemonSet, the question introduced in FAQ in official docs points to it, see and review the PR

furthermore, it contains links to the rationale for this change

Which issue this PR fixes

Closes Kong/kubernetes-ingress-controller#4728

Special notes for your reviewer:

Checklist

  • PR is based off the current tip of the main branch.
  • [ ] Changes are documented under the "Unreleased" header in CHANGELOG.md
  • [ ] New or modified sections of values.yaml are documented in the README.md
  • Commits follow the Kong commit message guidelines

@programmer04 programmer04 added the documentation Improvements or additions to documentation label Oct 30, 2023
@programmer04 programmer04 self-assigned this Oct 30, 2023
@programmer04 programmer04 requested a review from a team as a code owner October 30, 2023 13:58
@programmer04 programmer04 enabled auto-merge (squash) October 30, 2023 14:00
charts/kong/README.md Outdated Show resolved Hide resolved
@programmer04 programmer04 merged commit 4736b0d into main Oct 30, 2023
23 checks passed
@programmer04 programmer04 deleted the impr-daemon-set branch October 30, 2023 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Document when using DaemonSet makes sense
2 participants