feat: print diff info from cmd #1142
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #1142 +/- ##
========================================
+ Coverage 5.91% 6.70% +0.79%
========================================
Files 31 32 +1
Lines 3144 3205 +61
========================================
+ Hits 186 215 +29
- Misses 2948 2979 +31
- Partials 10 11 +1 ☔ View full report in Codecov by Sentry. |
rainest
force-pushed
the
chore/refactor-cprint
branch
from
b909868
to
5ea54ba
Compare
rainest
force-pushed
the
chore/refactor-cprint
branch
from
815a864
to
1ab954a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Leverages Kong/go-database-reconciler#30 to print diff output from the command code, rather than having the library code print directly. This allows removing cprint dependencies from the library.
Same breaking caveat applies: we are no longer printing at the time individual events happen. We collect evens and print them in a batch at the end. This change is notable but hopefully not a problem. Adding timestamps could recapture that information in a new format if needed.