Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add tls support to konnect client #1194

Merged
merged 1 commit into from
Feb 1, 2024
Merged

Conversation

GGabriele
Copy link
Collaborator

No description provided.

@GGabriele GGabriele force-pushed the feat/konnect-certs branch 2 times, most recently from 5786f78 to 7094cba Compare January 31, 2024 16:34
@codecov-commenter
Copy link

codecov-commenter commented Jan 31, 2024

Codecov Report

Attention: 30 lines in your changes are missing coverage. Please review.

Comparison is base (da7aa1d) 5.56% compared to head (1f77e18) 5.53%.
Report is 1 commits behind head on main.

Files Patch % Lines
cmd/root.go 0.00% 17 Missing ⚠️
cmd/common_konnect.go 0.00% 7 Missing ⚠️
cmd/gateway_ping.go 0.00% 5 Missing ⚠️
cmd/common.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff            @@
##            main   #1194      +/-   ##
========================================
- Coverage   5.56%   5.53%   -0.04%     
========================================
  Files         32      32              
  Lines       3341    3360      +19     
========================================
  Hits         186     186              
- Misses      3145    3164      +19     
  Partials      10      10              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@GGabriele GGabriele marked this pull request as ready for review February 1, 2024 08:23
@GGabriele GGabriele requested a review from a team as a code owner February 1, 2024 08:23
Copy link
Member

@Tieske Tieske left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@GGabriele GGabriele merged commit 018b12b into main Feb 1, 2024
38 of 39 checks passed
@GGabriele GGabriele deleted the feat/konnect-certs branch February 1, 2024 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants