fix: do not fetch kong version when running validate
#1247
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
decK used to fetch the running Kong version in order to gate route regex patterns validation. This is problematic in the case users don't have access to the `/` endpoint, which is the one used to fetch the version of the runtime. This commit removes the need of fetching the Kong version entirely by relying on the `_format_version` field from the config file instead.
Tieske
approved these changes
Mar 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
decK used to fetch the running Kong version in order to gate route regex patterns validation. This is problematic in the case users don't have access to the
/endpoint, which is the one used to fetch the version of the runtime.This commit removes the need of fetching the Kong version entirely by relying on the
_format_versionfield from the config file instead.