-
Notifications
You must be signed in to change notification settings - Fork 128
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: mask environment variables from outputs #463
feat: mask environment variables from outputs #463
Conversation
8352c00
to
b516e5f
Compare
Just wondering what the status was on this PR? We noticed that the |
Can confirm this is also causing us problem across all our environments. More than happy to contribute or review any supporting PRs if that's of any use? |
This looks promising. Could you please add an integration test for this? |
b516e5f
to
370749b
Compare
083ef36
to
63cb183
Compare
@hbagdi TBH I have no idea how to create a "diff" integration test that actually looks to the diff output 😞
|
@GGabriele Could you help out, please? |
Hi @carnei-ro , thanks for this very nice feature AND apologies for the super late response! The trick here would be to capture the output from the decK command and compare it to some expected one. Behind the scenes, decK uses In order to redirect the output to something we can use during tests, we can overwrite color.Output in our
At that point, you can compare
|
b7aac32
to
d1c00da
Compare
Thanks @GGabriele it really did the job. Masked and Unmasked for Kong < 3 and Kong >= 3 tests are there! |
d1c00da
to
a137fdd
Compare
a137fdd
to
df7bd57
Compare
df7bd57
to
e65a146
Compare
@carnei-ro I just added a couple of more comments which would require a bit of refactoring (sorry for not pushing these earlier). @rainest can you take a look at this PR too? I want to make sure KIC is good with these changes (and the ones I proposed) |
@carnei-ro Awesome job here! Merging this now, thanks a lot again! |
@GGabriele, thanks for merging it! Does decK project have custom contributor T-shirts? I'm collecting them - I already have Kong, KIC and it would be great to have one of decK. |
Unfortunately it doesn't :( not yet at least |
This commit fixes a 'visual' regression introduced in #463, which is making decK print full diff documents for 'create' and 'delete' actions. This can result in very verbose output in case of configuration files containing hundreds/thousands of resources.
This commit fixes a 'visual' regression introduced in #463, which is making decK print full diff documents for 'create' and 'delete' actions. This can result in very verbose output in case of configuration files containing hundreds/thousands of resources.
This commit fixes a 'visual' regression introduced in #463, which is making decK print full diff documents for 'create' and 'delete' actions. This can result in very verbose output in case of configuration files containing hundreds/thousands of resources.
This commit fixes a 'visual' regression introduced in #463, which is making decK print full diff documents for 'create' and 'delete' actions. This can result in very verbose output in case of configuration files containing hundreds/thousands of resources.
fixes #462