Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kic: add section about events for cluster scoped resources #7203

Merged
merged 2 commits into from
Apr 12, 2024

Conversation

pmalek
Copy link
Member

@pmalek pmalek commented Apr 10, 2024

Description

Adds a section about Events for cluster scoped resources

Relevant KIC issue: Kong/kubernetes-ingress-controller#5847

Testing instructions

Preview link:

Checklist

For example, if this change is for an upcoming 3.6 release, enclose your content in {% if_version gte:3.6.x %} <content> {% endif_version %} tags (or if_plugin_version tags for plugins).

Use any of the following keys:

  • gte:<version> - greater than or equal to a specific version
  • lte:<version> - less than or equal to a specific version
  • eq:<version> - exactly equal to a specific version

You can do the same for older versions.

@pmalek pmalek added team-k8s Kubernetes task tracking (including KIC,KGO) review:general Review for general accuracy and presentation. Does the doc work? Does it output correctly? review:sme Request for SME review, external to the docs team. labels Apr 10, 2024
Copy link

netlify bot commented Apr 10, 2024

Deploy Preview for kongdocs ready!

Name Link
🔨 Latest commit 6d5b7cf
🔍 Latest deploy log https://app.netlify.com/sites/kongdocs/deploys/6618f8e7ae5ccd0008ea7d60
😎 Deploy Preview https://deploy-preview-7203--kongdocs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
9 paths audited
Performance: 95 (🟢 up 3 from production)
Accessibility: 93 (no change from production)
Best Practices: 98 (🟢 up 8 from production)
SEO: 91 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@pmalek pmalek requested a review from a team April 10, 2024 10:58
Copy link
Contributor

@czeslavo czeslavo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@pmalek pmalek marked this pull request as ready for review April 10, 2024 11:16
@pmalek pmalek requested a review from a team as a code owner April 10, 2024 11:16
@cloudjumpercat cloudjumpercat self-assigned this Apr 11, 2024
Copy link
Contributor

@cloudjumpercat cloudjumpercat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pmalek Thanks for writing this up! I've left some suggested edits, just small stuff. Once you add those in, I'll make sure to approve and merge this!

Co-authored-by: Diana <75819066+cloudjumpercat@users.noreply.github.com>
Copy link
Contributor

@cloudjumpercat cloudjumpercat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@cloudjumpercat cloudjumpercat merged commit 25eaa90 into main Apr 12, 2024
15 checks passed
@cloudjumpercat cloudjumpercat deleted the kic-k8s-events-cluster-scoped branch April 12, 2024 20:00
mheap pushed a commit that referenced this pull request Apr 16, 2024
* kic: add section about events for cluster scoped resources

* Apply suggestions from code review

Co-authored-by: Diana <75819066+cloudjumpercat@users.noreply.github.com>

---------

Co-authored-by: Diana <75819066+cloudjumpercat@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
review:general Review for general accuracy and presentation. Does the doc work? Does it output correctly? review:sme Request for SME review, external to the docs team. team-k8s Kubernetes task tracking (including KIC,KGO)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants