-
Notifications
You must be signed in to change notification settings - Fork 595
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
kic: add section about events for cluster scoped resources #7203
Conversation
✅ Deploy Preview for kongdocs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@pmalek Thanks for writing this up! I've left some suggested edits, just small stuff. Once you add those in, I'll make sure to approve and merge this!
app/_src/kubernetes-ingress-controller/production/observability/events.md
Outdated
Show resolved
Hide resolved
app/_src/kubernetes-ingress-controller/production/observability/events.md
Outdated
Show resolved
Hide resolved
app/_src/kubernetes-ingress-controller/production/observability/events.md
Outdated
Show resolved
Hide resolved
app/_src/kubernetes-ingress-controller/production/observability/events.md
Outdated
Show resolved
Hide resolved
app/_src/kubernetes-ingress-controller/production/observability/events.md
Outdated
Show resolved
Hide resolved
app/_src/kubernetes-ingress-controller/production/observability/events.md
Outdated
Show resolved
Hide resolved
Co-authored-by: Diana <75819066+cloudjumpercat@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
* kic: add section about events for cluster scoped resources * Apply suggestions from code review Co-authored-by: Diana <75819066+cloudjumpercat@users.noreply.github.com> --------- Co-authored-by: Diana <75819066+cloudjumpercat@users.noreply.github.com>
Description
Adds a section about Events for cluster scoped resources
Relevant KIC issue: Kong/kubernetes-ingress-controller#5847
Testing instructions
Preview link:
Checklist
For example, if this change is for an upcoming 3.6 release, enclose your content in
{% if_version gte:3.6.x %} <content> {% endif_version %}
tags (orif_plugin_version
tags for plugins).Use any of the following keys:
gte:<version>
- greater than or equal to a specific versionlte:<version>
- less than or equal to a specific versioneq:<version>
- exactly equal to a specific versionYou can do the same for older versions.