[openapi2kong] Fix server port parsing #105
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #105 +/- ##
==========================================
- Coverage 70.28% 70.20% -0.08%
==========================================
Files 17 17
Lines 2453 2457 +4
==========================================
+ Hits 1724 1725 +1
- Misses 611 614 +3
Partials 118 118
☔ View full report in Codecov by Sentry. |
Tieske
requested changes
Nov 9, 2023
openapi2kong/service.go
Outdated
| @@ -230,7 +230,11 @@ func CreateKongService( | |||
| if service["port"] == nil { | |||
| if targets[0].Port() != "" { | |||
| // port is provided, so parse it | |||
| service["port"], _ = strconv.ParseInt(targets[0].Port(), 10, 16) | |||
| parsedPort, err := strconv.ParseInt(targets[0].Port(), 10, 64) | |||
There was a problem hiding this comment.
I think using ParseUint with bitsize 16 should do it right? That would also ensure any negative numbers are caught by the error handler.
Tieske
force-pushed
the
fix-server-port
branch
from
6e04a85
to
5f4d4d5
Compare
Tieske
force-pushed
the
fix-server-port
branch
from
5f4d4d5
to
e66e7e6
Compare
Tieske
approved these changes
Nov 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#104
This change increases bit size in
strconv.ParseIntfrom 16 to 64 to allow higher port numbers. Also previously when the input was unparseable, the error was ignored. Now we can return an error instead of silently setting a potentially incorrect port number.