feat: adding validate and unload plugin schema functionality #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikefero
commented
May 13, 2022
| return nil, tostring(errors:schema_violation(err_t)) | ||
| end | ||
| return plugin_schema.name, nil | ||
| end |
There was a problem hiding this comment.
In future versions of goks we might want to consider removing the code duplication in load_plugin_schema and update the signature to require the plugin_name and plugin_schema_string. If we decide to keep the schema validation in the load_plugin_schema function we should look at using local functions and exposing them in the return in order to remove some duplicated code.
GGabriele
reviewed
May 13, 2022
GGabriele
reviewed
May 13, 2022
tjasko
reviewed
May 16, 2022
hbagdi
reviewed
May 16, 2022
mikefero
commented
May 17, 2022
hbagdi
reviewed
May 17, 2022
mikefero
force-pushed
the
validate-and-unload-schema
branch
from
2c2ac15
to
6edbe46
Compare
These feature additions allow for plugin: * validating of schema; validates and tests loading of plugin schema * unloading of plugin schemas; useful for removing a plugin schema during runtime
mikefero
force-pushed
the
validate-and-unload-schema
branch
from
6edbe46
to
8ce5395
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These feature additions allow for plugin: